OIDC/sdk google recovery flow#69
Merged
matias-gonz merged 27 commits intofeat/oidc-account-recoveryfrom Feb 19, 2025
Merged
Conversation
matias-gonz
changed the base branch from
feat/oidc-account-recovery
to
oidc/add-google-recovery-flow
calvogenerico
approved these changes
Feb 18, 2025
| recovery: "0x4E619cA9DDb3A207E4764F3Ee5D36DD478212335", | ||
| recoveryOidc: "0x3ad654fC38bb5Abe789c912cfE900A867d52A164", | ||
| accountFactory: "0x01F99512191c036FcA9Fcd416dE73b19e93B7D60", | ||
| accountPaymaster: "0x2A2869fa5a1E94474798C02ED930278C154EE213", |
There was a problem hiding this comment.
Can we research if nuxt offers a better way to save this kind of data? It's kind of awful having to update this on every deploy. Maybe we can do something were the deploy script exports the addresses in some format that we can use as an input for this.
Not for this PR, though.
Member
Author
There was a problem hiding this comment.
I will add it to the backlog
|
|
||
| return await client.addOidcAccount({ | ||
| paymaster: { | ||
| address: paymasterAddress, |
There was a problem hiding this comment.
We have to ask about using the paymaster for these txs.
…s/zksync-sso into oidc/sdk-google-recovery-flow
…ksync-sso into oidc/add-google-recovery-flow
…s/zksync-sso into oidc/sdk-google-recovery-flow
Base automatically changed from
oidc/add-google-recovery-flow
to
feat/oidc-account-recovery
February 19, 2025 11:53
|
Visit the preview URL for this PR (updated for commit 749e76a): https://zksync-auth-server-staging--pr69-oidc-sdk-google-reco-64lgfi8k.web.app (expires Wed, 26 Feb 2025 11:57:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add Recover with Google button * Add GoogleFlow * Add useAddOidcAccount * feat: add OidcValidator to account * Add OidcRecoveryModuleAbi * Add addOidcAccount to client * Add addOidcAccount calldata * Fix ABI * fix: encodedOidcData * feat: add oidcData parameter * lint: sdk * chore: lint oidc key registry server * chore: lint auth-server * chore: lint md * chore: run prettier * chore: add keywords to cspell * chore: add keywords to cspell * chore: update lock file * chore: run prettier * chore: lint auth-server * chore: lint oidc key registry server * fix: zeek nft * fix: zeek nft
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add Recover with Google button * Add GoogleFlow * Add useAddOidcAccount * feat: add OidcValidator to account * Add OidcRecoveryModuleAbi * Add addOidcAccount to client * Add addOidcAccount calldata * Fix ABI * fix: encodedOidcData * feat: add oidcData parameter * lint: sdk * chore: lint oidc key registry server * chore: lint auth-server * chore: lint md * chore: run prettier * chore: add keywords to cspell * chore: add keywords to cspell * chore: update lock file * chore: run prettier * chore: lint auth-server * chore: lint oidc key registry server * fix: zeek nft * fix: zeek nft
cpb8010
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Add Recover with Google button * Add GoogleFlow * Add useAddOidcAccount * feat: add OidcValidator to account * Add OidcRecoveryModuleAbi * Add addOidcAccount to client * Add addOidcAccount calldata * Fix ABI * fix: encodedOidcData * feat: add oidcData parameter * lint: sdk * chore: lint oidc key registry server * chore: lint auth-server * chore: lint md * chore: run prettier * chore: add keywords to cspell * chore: add keywords to cspell * chore: update lock file * chore: run prettier * chore: lint auth-server * chore: lint oidc key registry server * fix: zeek nft * fix: zeek nft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates OidcRecoveryValidator contract with SDK